-
Notifications
You must be signed in to change notification settings - Fork 990
Fix invalid related commands #3591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gururajsh
merged 3 commits into
cloudfoundry:v8
from
marckhouzam:marck/noRenameBuildpack
Oct 30, 2025
Merged
Fix invalid related commands #3591
gururajsh
merged 3 commits into
cloudfoundry:v8
from
marckhouzam:marck/noRenameBuildpack
Oct 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I will fix the integration tests as soon as I find time. |
5985b93 to
a6d6368
Compare
anujc25
reviewed
Oct 16, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment but otherwise LGTM once the integration test is fixed.
a6d6368 to
7966af0
Compare
"rename-buildpack" no longer exists as a command: it was removed by commit ba9cea0. Signed-off-by: Marc Khouzam <[email protected]>
Signed-off-by: Marc Khouzam <[email protected]>
7966af0 to
42b74ce
Compare
Signed-off-by: Marc Khouzam <[email protected]>
42b74ce to
2f1d5cb
Compare
gururajsh
approved these changes
Oct 30, 2025
Member
gururajsh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
marckhouzam
added a commit
to marckhouzam/cf-cli
that referenced
this pull request
Oct 30, 2025
* Remove mention of rename-buildpack in related cmds "rename-buildpack" no longer exists as a command: it was removed by commit ba9cea0. * Another invalid related_command: delete-plugin-repo * Another invalid related command: delete-routes Signed-off-by: Marc Khouzam <[email protected]>
gururajsh
pushed a commit
that referenced
this pull request
Oct 30, 2025
* Remove mention of rename-buildpack in related cmds "rename-buildpack" no longer exists as a command: it was removed by commit ba9cea0. * Another invalid related_command: delete-plugin-repo * Another invalid related command: delete-routes Signed-off-by: Marc Khouzam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
rename-buildpackdelete-plugin-repowithremove-plugin-repodelete-routestodelete-route"rename-buildpack" no longer exists as a command: it was removed by commit ba9cea0.
Note that the command is still part of the
command/common/internal/help_all_display.gofile but when I trycf help -athere is an empty line where I would have expected to see this command. I'm not exactly sure what kind of magic is going on there.Why Is This PR Valuable?
Showing invalid commands
in theSEE ALSO` section of the help is wrong and confusingHow Urgent Is The Change?
Not urgent.